Re: [PATCH] workqueue: Use the kmem_cache_free() instead of kfree() to release pwq

[Z qiang]

>
> On Sat, Oct 07, 2023 at 07:35:41PM +0800, Zqiang wrote:
> > The pwq objects is allocated by kmem_cache_alloc(), this commit therefore
> > use kmem_cache_free() instead of kfree() to release pwq objects and also
> > make use the correct tracepoint("trace_kmem_cache_free") to trace the
> > release of pwq.
>
> This isn't wrong. kfree() can be used for memory allocated with
> kmem_cache_alloc().
>

Yes, that's not wrong.  but pwq is allocated by kmem_cache_alloc(),
usually should use kmem_cache_free() to release, correspondingly, we can
use 'trace_kmem_cache_alloc/trace_kmem_cache_free' to track, not using
'trace_kmem_cache_alloc/trace_kfree'.
And in rcu_free_pwq(), we use kmem_cache_free() to free pwq.

Thanks
Zqiang


>
> Thanks.
>
> --
> tejun