Re: [PATCH v8] hv/hv_kvp_daemon:Support for keyfile based connection profile

[Wei Liu]

On Mon, Oct 09, 2023 at 05:32:35PM +0530, Ani Sinha wrote:
> 
> 
> > On 09-Oct-2023, at 4:08 PM, Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > Ifcfg config file support in NetworkManger is deprecated. This patch
> > provides support for the new keyfile config format for connection
> > profiles in NetworkManager. The patch modifies the hv_kvp_daemon code
> > to generate the new network configuration in keyfile
> > format(.ini-style format) along with a ifcfg format configuration.
> > The ifcfg format configuration is also retained to support easy
> > backward compatibility for distro vendors. These configurations are
> > stored in temp files which are further translated using the
> > hv_set_ifconfig.sh script. This script is implemented by individual
> > distros based on the network management commands supported.
> > For example, RHEL's implementation could be found here:
> > https://gitlab.com/redhat/centos-stream/src/hyperv-daemons/-/blob/c9s/hv_set_ifconfig.sh
> > Debian's implementation could be found here:
> > https://github.com/endlessm/linux/blob/master/debian/cloud-tools/hv_set_ifconfig
> > 
> > The next part of this support is to let the Distro vendors consume
> > these modified implementations to the new configuration format.
> > 
> > Tested-on: Rhel9(Hyper-V, Azure)(nm and ifcfg files verified)
> > Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Ani Sinha <anisinha@xxxxxxxxxx>

Applied to hyperv-fixes. Thanks.