Re: [PATCH] net: ipv6: fix return value check in esp_remove_trailer

From: Herbert Xu
Date: Tue Oct 10 2023 - 05:04:13 EST


On Sun, Oct 08, 2023 at 10:07:30AM -0700, Cong Wang wrote:
> On Sat, Oct 07, 2023 at 08:59:53AM +0800, Ma Ke wrote:
> > In esp_remove_trailer(), to avoid an unexpected result returned by
> > pskb_trim, we should check the return value of pskb_trim().
> >
> > Signed-off-by: Ma Ke <make_ruc2021@xxxxxxx>
> > ---
> > net/ipv6/esp6.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> We need the same change for net/ipv4/esp4.c?

Please verify that it can actually fail first. Note that I'm
busy right now so I haven't looked at it at all.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt