Re: [PATCH 05/11] dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core

[Serge Semin]

On Mon, Oct 09, 2023 at 05:32:57PM +0200, Gregory CLEMENT wrote:
> Rob Herring <robh@xxxxxxxxxx> writes:
> 
> > On Fri, Oct 06, 2023 at 12:48:03PM +0200, Arnd Bergmann wrote:
> >> On Thu, Oct 5, 2023, at 16:51, Gregory CLEMENT wrote:
> >> >> On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote:
> >> >>> The MIPS Warrior I-class I6500 was announced by Imagination
> >> >>> Technologies in 2016 and is used in the Mobileye SoC EyeQ5.
> >> >>> 
> >> >>> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> >> >>> ---
> >> >>>  Documentation/devicetree/bindings/mips/cpus.yaml | 1 +
> >> >>>  1 file changed, 1 insertion(+)
> >> >>> 
> >> >>> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml
> >> >>> index cf382dea3922..87fd2842ba68 100644
> >> >>> --- a/Documentation/devicetree/bindings/mips/cpus.yaml
> >> >>> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml
> >> >>> @@ -39,6 +39,7 @@ properties:
> >> >>>        - mti,mips24KEc
> >> >>>        - mti,mips14KEc
> >> >>>        - mti,mips14Kc
> >> >>
> >> >>> +      - mti,i6500
> >> >>
> >> >> Since the CPU core vendor is Imagination Technologies thus it would
> >> >> be more appropriate to have the "img," prefix. Wouldn't it?
> >> >
> >> > According to Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> >
> >> > "^mti,.*":
> >> >     description: Imagination Technologies Ltd. (formerly MIPS
> >> >     Technologies Inc.)
> >> >
> >> > So I think it's OK.
> >> 
> >> I don't see any good solution, they changed their name and
> >> ownership too many times. I would actually revert back the
> >> description here to "MIPS Technologies Inc" instead of trying
> >> to keep track of what they currently call themselves.
> >> 
> >> Since we already have both the 'mips,' and 'mti,' vendow
> >> names for the 14Kc, 14KEc and 24KEc parts, maybe we can
> >> just go back to 'mips,' for all cores past the mti era
> >> rather than trying to date and geolocate each of the
> >> classic cores as one of 'mti', 'img', 'wavecomp', 'tallwood',
> >> 'mips' 'cipunited' etc.
> >
> > I would reserve 'mips' for anything common. Much like 'riscv' is only 
> > for things based on RiscV specs/standards.
> >
> > I would use 'img' here if we know this was designed/implemented by 
> > Imagination.
> 
> If there is no objection I will use 'img' then.

Sounds good. Thanks. Feel free to add then:
Acked-by: Serge Semin <fancer.lancer@xxxxxxxxx>

-Serge(y)

> 
> Gregory
> 
> >
> > Rob
> 
> -- 
> Gregory Clement, Bootlin
> Embedded Linux and Kernel engineering
> http://bootlin.com