Re: [PATCH] s390/cio: Fix a memleak in css_alloc_subchannel

From: Vasily Gorbik
Date: Tue Oct 10 2023 - 06:32:38 EST


On Thu, Oct 05, 2023 at 05:12:54PM +0200, Peter Oberparleiter wrote:
> On 21.09.2023 09:14, Dinghao Liu wrote:
> > When dma_set_coherent_mask() fails, sch->lock has not been
> > freed, which is allocated in css_sch_create_locks(), leading
> > to a memleak.
> >
> > Fixes: 4520a91a976e ("s390/cio: use dma helpers for setting masks")
> > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
>
> Looks good to me.
>
> Reviewed-by: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>

Applied, thank you.