Re: [PATCH v6 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work.

From: Cezary Rojewski
Date: Tue Oct 10 2023 - 07:53:45 EST


On 2023-10-10 1:43 PM, Cezary Rojewski wrote:
On 2023-10-04 4:55 PM, Maarten Lankhorst wrote:

...

@@ -465,10 +461,19 @@ static int avs_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
      pci_set_drvdata(pci, bus);
      device_disable_async_suspend(dev);
+    ret = snd_hdac_i915_init(bus, false);
+    if (ret == -EPROBE_DEFER)
+        goto err_i915_init;
+    else if (ret < 0)

The 'else' part seems redundant. s/else if/else/.

Spelling error on my part. What I meant is s/else if/if/.

+        dev_info(bus->dev, "i915 init unsuccessful: %d\n", ret);
+