Re: [PATCH v2 2/3] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding

From: Bryan O'Donoghue
Date: Tue Oct 10 2023 - 09:57:05 EST


On 10/10/2023 14:25, Rob Herring wrote:

On Tue, 10 Oct 2023 13:25:38 +0100, Bryan O'Donoghue wrote:
Add bindings for qcom,sc8280xp-camss in order to support the camera
subsystem for sc8280xp as found in the Lenovo x13s Laptop.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---
.../bindings/media/qcom,sc8280xp-camss.yaml | 582 ++++++++++++++++++
1 file changed, 582 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.example.dts:26:18: fatal error: dt-bindings/clock/qcom,sc8280xp-camcc.h: No such file or directory
26 | #include <dt-bindings/clock/qcom,sc8280xp-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I guess I should be embedding this


This patch depends-on:
https://lore.kernel.org/lkml/20231004161853.86382-2-bryan.odonoghue@xxxxxxxxxx/T/

or


This patch depends-on:
https://lore.kernel.org/lkml/20231004161853.86382-2-bryan.odonoghue@xxxxxxxxxx/T/#mc33be3fef01bffe892f72bd5e567dba6a047283b

below the "---" in this patch directly, instead of in the series description ?

---
bod