Re: [PATCH v3] ata: sata_mv: aspeed: fix value check in mv_platform_probe()

[Niklas Cassel]

On Tue, Oct 10, 2023 at 08:29:16PM +0800, Ma Ke wrote:
> In mv_platform_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
> 
> Signed-off-by: Ma Ke <make_ruc2021@xxxxxxx>
> ---
>  drivers/ata/sata_mv.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 45e48d653c60..e82786c63fbd 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -4123,10 +4123,13 @@ static int mv_platform_probe(struct platform_device *pdev)
>  	hpriv->base -= SATAHC0_REG_BASE;
>  
>  	hpriv->clk = clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(hpriv->clk))
> +	if (IS_ERR(hpriv->clk)) {
>  		dev_notice(&pdev->dev, "cannot get optional clkdev\n");
> -	else
> -		clk_prepare_enable(hpriv->clk);
> +	} else {
> +		rc = clk_prepare_enable(hpriv->clk);
> +		if (rc)
> +			goto err;
> +	}
>  
>  	for (port = 0; port < n_ports; port++) {
>  		char port_number[16];
> -- 
> 2.37.2
> 

Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>

Nit:
Instead of:
ata: sata_mv: aspeed: fix value check in mv_platform_probe()
something like:
ata: sata_mv: aspeed: check clk_prepare_enable() return code

Might be slightly more descriptive.

Will leave it up to the maintainer though.


Kind regards,
Niklas