Re: [PATCH v4] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for Micron eMMC Q2J54A

From: Bean Huo
Date: Tue Oct 10 2023 - 10:14:44 EST



Hi Ulf,

ping you again, have you recieved this mail?

Kind regards,
Bean


On Wed, 2023-10-04 at 21:07 +0200, Bean Huo wrote:
> Hi Ulf,
>
> Any comments on this version?
>
> Kind regards,
>
> Beam
>
> On 01.10.23 9:49 PM, Bean Huo wrote:
> > From: Bean Huo <beanhuo@xxxxxxxxxx>
> >
> > Micron MTFC4GACAJCN eMMC supports cache but requires that flush
> > cache
> > operation be allowed only after a write has occurred. Otherwise,
> > the
> > cache flush command or subsequent commands will time out.
> >
> > Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
> > Signed-off-by: Rafael Beims <rafael.beims@xxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> >
> > ---
> > Changelog:
> >
> > v3--v4:
> >       1. Add helper function for this quirk in
> > drivers/mmc/core/card.h.
> >       2. Set card->written_flag only for REQ_OP_WRITE.
> > v2--v3:
> >       1. Set card->written_flag in mmc_blk_mq_issue_rq().
> > v1--v2:
> >       1. Add Rafael's test-tag, and Co-developed-by.
> >       2. Check host->card whether NULL or not in
> > __mmc_start_request() before asserting host->card->->quirks