Re: [PATCH net-next v7] hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

[Simon Horman]

On Mon, Oct 09, 2023 at 01:00:16AM -0700, Sonia Sharma wrote:
> From: Sonia Sharma <sonia.sharma@xxxxxxxxxxxxxxxxxxx>
> 
> The switch statement in netvsc_send_completion() is incorrectly validating
> the length of incoming network packets by falling through to the next case.
> Avoid the fallthrough. Instead break after a case match and then process
> the complete() call.
> The current code has not caused any known failures. But nonetheless, the
> code should be corrected as a different ordering of the switch cases might
> cause a length check to fail when it should not.
> 
> Signed-off-by: Sonia Sharma <sonia.sharma@xxxxxxxxxxxxxxxxxxx>
> 
> ---
> Changes in v3:
> * added return statement in default case as pointed by Michael Kelley.
> Changes in v4:
> * added fixes tag
> * modified commit message to explain the issue fixed by patch.
> Changes in v5:
> * Dropped fixes tag as suggested by Simon Horman.
> * fixed indentation
> Changes in v7:
> * Dropped the prefix "net" from subject line.

This seems address the concerns raised by Michael Kelly in his review of v6.

It doesn't include his (or my) Reviewed-by tag(s).
That not withstanding the logic change and overall patch looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>