Re: [PATCH v2 -tip] x86/percpu: Use C for arch_raw_cpu_ptr()

From: Uros Bizjak
Date: Tue Oct 10 2023 - 14:41:48 EST


On Tue, Oct 10, 2023 at 8:38 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 10 Oct 2023 at 11:22, Uros Bizjak <ubizjak@xxxxxxxxx> wrote:
> >
> > Please note that besides propagation of the addition into address, the
> > patch also exposes memory load to the compiler, with the anticipation
> > that the compiler CSEs the load from this_cpu_off from eventual
> > multiple addresses. For this to work, we have to get rid of the asms.
>
> I actually checked that the inline asm gets combined, the same way the
> this_cpu_read_stable cases do (which we use for 'current').

Yes, but does it CSE the load from multiple addresses?

Uros.