Re: renesas_sdhi problems in 5.10-stable was Re: [PATCH 5.10 000/226] 5.10.198-rc1 review

[Greg Kroah-Hartman]

On Tue, Oct 10, 2023 at 09:07:01PM +0200, Wolfram Sang wrote:
> Hi Pavel,
> 
> > And testing failed. So
> > 
> > commit f5799b4e142884c2e7aa99f813113af4a3395ffb
> > Author: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> > Date:   Tue Nov 10 15:20:57 2020 +0100
> > 
> >     mmc: renesas_sdhi: populate SCC pointer at the proper place
> >     
> >     [ Upstream commit d14ac691bb6f6ebaa7eeec21ca04dd47300ff5b6 ]
> > 
> > seems to be the buggy commit that breaks renesas boards in 5.10.
> 
> This patch was part of a series. Did the other two patches come with it?
> 
> b161d87dfd3d ("mmc: renesas_sdhi: probe into TMIO after SCC parameters have been setup")

Yes.

> 45bffc371fef ("mmc: renesas_sdhi: only reset SCC when its pointer is populated")

No :(

> If not, I could imagine that could lead to a crash. No idea why only
> with 5.10, though.

The above commit is only in 5.11, so newer kernels should be fine.

I'll go queue up the one missing patch now, thanks.

greg k-h