Re: [PATCH v5 0/2] add NPCM SDHCI driver support

[Tomer Maimon]

Thank a lot Ulf

Appreciate it!

On Tue, 10 Oct 2023 at 17:28, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
> On Mon, 2 Oct 2023 at 22:06, Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:
> >
> > This patch set adds SDHCI support for the Nuvoton NPCM Baseboard
> > Management Controller (BMC).
> >
> > Deeply sorry it took that long until sending version three, promise to try
> > to do better on the next versions (if needed) :-),
> >
> > The NPCM SDHCI driver tested on NPCM750 and NPCM845 EVB.
> >
> > Addressed comments from:
> >  - Andy Shevchenko : https://www.spinics.net/lists/devicetree/msg638000.html
> >
> > Changes since version 4:
> >  - Remove unnecessary clk_disable_unprepare function.
> >
> > Changes since version 3:
> >  - Use devm_clk_get_optional_enabled function.
> >  - Add mod_devicetable.h.
> >  - Modify copyright year.
> >
> > Changes since version 2:
> >  - Add data to handle architecture-specific SDHCI parameters.
> >  - Change config place in make and kconfig files.
> >  - Calling sdhci_pltfm_free to to avoid a memory leak on error.
> >
> > Changes since version 1:
> >  - Use correct spaces in the dt-bindings.
> >  - Drop unused labels from dt-bindings.
> >  - Order by module name in the make a configuration.
> >  - Remove unnecessary blank lines.
> >  - Using devm_clk_get_optional instead of devm_clk_get.
> >
> > Tomer Maimon (2):
> >   dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller
> >   mmc: sdhci-npcm: Add NPCM SDHCI driver
> >
> >  .../devicetree/bindings/mmc/npcm,sdhci.yaml   | 45 +++++++++
> >  drivers/mmc/host/Kconfig                      |  8 ++
> >  drivers/mmc/host/Makefile                     |  1 +
> >  drivers/mmc/host/sdhci-npcm.c                 | 94 +++++++++++++++++++
> >  4 files changed, 148 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml
> >  create mode 100644 drivers/mmc/host/sdhci-npcm.c
> >
>
> Applied for next (and by amending patch2 to remove some commas), thanks!
>
> Kind regards
> Uffe