Re: [PATCH] net: dsa: vsc73xx: replace deprecated strncpy with ethtool_sprintf

[Vladimir Oltean]

On Tue, Oct 10, 2023 at 02:49:26PM -0700, Justin Stitt wrote:
> On Tue, Oct 10, 2023 at 4:20 AM Vladimir Oltean <olteanv@xxxxxxxxx> wrote:
> > Here you don't use "%s", but everywhere else you do. Can't you just pass
> > the counter name everywhere, without "%s"?
> 
> Because it's a string literal, no warning there. Maybe an argument
> regarding style could be made. I have no style preference here
> so I could send v2 if you feel strongly about it.

No, leave it alone here, don't add the "%s" where it's not needed.
But I guess you'll have to send a v2 anyway due to the other comment.