Re: [PATCH] Remove extra unlock for the mutex
From: Florian Fainelli
Date: Tue Oct 10 2023 - 18:51:38 EST
On 10/10/23 15:46, Abhinav Singh wrote:
There is a double unlock on mutex. This can cause undefined behaviour.
Where is the double unlock of head->lock (which is a spinlock and not a
mutex, btw)?
Signed-off-by: Abhinav Singh <singhabhinav9051571833@xxxxxxxxx>
---
net/ipv4/inet_connection_sock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index aeebe8816689..f11fe8c727a4 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -597,7 +597,6 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)
}
if (head2_lock_acquired)
spin_unlock(&head2->lock);
- spin_unlock_bh(&head->lock);
return ret;
}
EXPORT_SYMBOL_GPL(inet_csk_get_port);
--
Florian