Re: [PATCH] watchdog: marvell_gti: Replace of_platform.h with explicit includes

From: Guenter Roeck
Date: Tue Oct 10 2023 - 19:48:10 EST


On Tue, Oct 10, 2023 at 03:56:36PM -0500, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other and pull in various other headers. In
> preparation to fix this, adjust the includes for what is actually needed.
>
> of_platform.h isn't needed, but of.h was implicitly included by it (via
> of_device.h).
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> Note this was added in the merge window and missed the last round.
> ---
> drivers/watchdog/marvell_gti_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_gti_wdt.c
> index d7eb8286e11e..01e9177cbf20 100644
> --- a/drivers/watchdog/marvell_gti_wdt.c
> +++ b/drivers/watchdog/marvell_gti_wdt.c
> @@ -8,8 +8,8 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
> -#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> +#include <linux/of.h>
> #include <linux/watchdog.h>
>
> /*
> --
> 2.42.0
>