Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

From: Stephen Hemminger
Date: Tue Oct 10 2023 - 22:15:53 EST


On Tue, 10 Oct 2023 22:59:49 +0000
Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> wrote:

> > > If this an application specific optimization, it should be in a socket option
> > > rather than system wide via sysctl.
> > Initially I had a similar comment but later decided a sysctl could
> > still be useful if
> > 1) the entire host (e.g. virtual machine) is dedicated to that application
> > 2) that application is difficult to change
>
> Yes, the customer actually wants a global setting. But as suggested by Neal,
> I changed it to be per-namespace to match other TCP tunables.

Like congestion control choice, it could be both a sysctl and a socket option.
The reason is that delayed ack is already controlled by socket options.