Re: [PATCH] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with ARM_SCMI_CPUFREQ

From: Viresh Kumar
Date: Wed Oct 11 2023 - 01:23:06 EST


On 10-10-23, 11:16, Florian Fainelli wrote:
> The brcmstb-avs-cpufreq driver is considered a legacy driver and since
> 2018, ARCH_BRCMSTB systems have been using scmi-cpufreq. As a matter of
> fact, when SCMI is in use, brcmstb-avs-cpufreq is unusable since the
> SCMI firmware takes over, this can result in various problems, including
> external synchronous aborts.
>
> Express those constraints such that the driver is not enabled by default
> when SCMI CPU frequency scaling is in use.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> ---
> drivers/cpufreq/Kconfig.arm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 123b4bbfcfee..c287305820b7 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -90,7 +90,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ
>
> config ARM_BRCMSTB_AVS_CPUFREQ
> tristate "Broadcom STB AVS CPUfreq driver"
> - depends on ARCH_BRCMSTB || COMPILE_TEST
> + depends on ARCH_BRCMSTB && !(ARM_SCMI_PROTOCOL && ARM_SCMI_CPUFREQ) || COMPILE_TEST

ARM_SCMI_CPUFREQ already implies ARM_SCMI_PROTOCOL, you don't need to
add both here.

--
viresh