Re: [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top

From: Florian Eckert
Date: Wed Oct 11 2023 - 02:59:02 EST


Hello Lee,

I only got reviews for the fixes and preparations for commits that change the
tty subsystem, but no reaction from the maintainer of the feature I want to
add to ledtrig-tty for v1 and v2 patchset.

How should I proceed? Send a v3 with the the requested changes.

[Patch v2 1/4]: https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@xxxxxxxxxx/T/#m913d3822465f35b54dfa24b1dfe4d50e61352980
Change got a 'Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>'.
Will add this to an upcoming v3 again.

[Patch v2 2/4] : https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@xxxxxxxxxx/T/#m7ee7618894a66fd3c89bed488a2394265a3f8df1
I missed to add the robot error message to the commit message and also missed
to add the the following 'Reported-by: kernel test robot <lkp@xxxxxxxxx>' and
'Closes: https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@xxxxxxxxx/'
to the commit message. Will add this to an upcoming v3.

And do not wait for the review of the following patches.
https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@xxxxxxxxxx/T/#mc0ecb912fa0e59015ad0a9b4cb491ae9f18c1ea9
https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@xxxxxxxxxx/T/#mba36217323c386ecd900e188bbdf6276c3c96c91

---

Florian