Re: [PATCH v1 1/1] spi: Don't use flexible array in struct spi_message definition
From: Marc Kleine-Budde
Date: Wed Oct 11 2023 - 03:00:46 EST
On 10.10.2023 19:31:00, Andy Shevchenko wrote:
> The struct spi_message can be embedded into another structures.
> With that the flexible array might be problematic as sparse
> complains about it, although there is no real issue in the code
> because when the message is embedded it doesn't use flexible array
> member. That memeber is a private to spi_message_alloc() API, so
> move it to that API in a form of an inherited data type.
>
> Reported-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Fixes: 75e308ffc4f0 ("spi: Use struct_size() helper"))
> Closes: https://lore.kernel.org/r/20231009-onshore-underage-c58415adfd92-mkl@xxxxxxxxxxxxxx
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Thank you for the timely fix!
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature