Re: [PATCH 01/10] appletalk: remove localtalk and ppp support
From: kernel test robot
Date: Wed Oct 11 2023 - 05:29:05 EST
Hi Arnd,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20231009]
[cannot apply to linus/master v6.6-rc5 v6.6-rc4 v6.6-rc3 v6.6-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/ieee802154-avoid-deprecated-ndo_do_ioctl-callback/20231009-222305
base: next-20231009
patch link: https://lore.kernel.org/r/20231009141908.1767241-1-arnd%40kernel.org
patch subject: [PATCH 01/10] appletalk: remove localtalk and ppp support
config: x86_64-randconfig-002-20231011 (https://download.01.org/0day-ci/archive/20231011/202310111736.4mh6Cf5C-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231011/202310111736.4mh6Cf5C-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310111736.4mh6Cf5C-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/net/appletalk/ipddp.c: In function 'ipddp_create':
drivers/net/appletalk/ipddp.c:207:24: error: implicit declaration of function 'atrtr_get_dev'; did you mean 'to_net_dev'? [-Werror=implicit-function-declaration]
if ((rt->dev = atrtr_get_dev(&rt->at)) == NULL) {
^~~~~~~~~~~~~
to_net_dev
>> drivers/net/appletalk/ipddp.c:207:22: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((rt->dev = atrtr_get_dev(&rt->at)) == NULL) {
^
cc1: some warnings being treated as errors
vim +207 drivers/net/appletalk/ipddp.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 192
^1da177e4c3f41 Linus Torvalds 2005-04-16 193 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 194 * Create a routing entry. We first verify that the
^1da177e4c3f41 Linus Torvalds 2005-04-16 195 * record does not already exist. If it does we return -EEXIST
^1da177e4c3f41 Linus Torvalds 2005-04-16 196 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 197 static int ipddp_create(struct ipddp_route *new_rt)
^1da177e4c3f41 Linus Torvalds 2005-04-16 198 {
ce7e40c432ba84 Vlad Tsyrklevich 2017-01-09 199 struct ipddp_route *rt = kzalloc(sizeof(*rt), GFP_KERNEL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 200
^1da177e4c3f41 Linus Torvalds 2005-04-16 201 if (rt == NULL)
^1da177e4c3f41 Linus Torvalds 2005-04-16 202 return -ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 203
^1da177e4c3f41 Linus Torvalds 2005-04-16 204 rt->ip = new_rt->ip;
^1da177e4c3f41 Linus Torvalds 2005-04-16 205 rt->at = new_rt->at;
^1da177e4c3f41 Linus Torvalds 2005-04-16 206 rt->next = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @207 if ((rt->dev = atrtr_get_dev(&rt->at)) == NULL) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 208 kfree(rt);
^1da177e4c3f41 Linus Torvalds 2005-04-16 209 return -ENETUNREACH;
^1da177e4c3f41 Linus Torvalds 2005-04-16 210 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 211
5615968a708451 David S. Miller 2009-05-27 212 spin_lock_bh(&ipddp_route_lock);
5615968a708451 David S. Miller 2009-05-27 213 if (__ipddp_find_route(rt)) {
5615968a708451 David S. Miller 2009-05-27 214 spin_unlock_bh(&ipddp_route_lock);
^1da177e4c3f41 Linus Torvalds 2005-04-16 215 kfree(rt);
^1da177e4c3f41 Linus Torvalds 2005-04-16 216 return -EEXIST;
^1da177e4c3f41 Linus Torvalds 2005-04-16 217 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 218
^1da177e4c3f41 Linus Torvalds 2005-04-16 219 rt->next = ipddp_route_list;
^1da177e4c3f41 Linus Torvalds 2005-04-16 220 ipddp_route_list = rt;
^1da177e4c3f41 Linus Torvalds 2005-04-16 221
5615968a708451 David S. Miller 2009-05-27 222 spin_unlock_bh(&ipddp_route_lock);
5615968a708451 David S. Miller 2009-05-27 223
^1da177e4c3f41 Linus Torvalds 2005-04-16 224 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 225 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 226
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki