Re: [PATCH v3 0/6] PCI/treewide: Cleanup/streamline PCI error code handling

[Ilpo Järvinen]

On Tue, 10 Oct 2023, Bjorn Helgaas wrote:

> [+cc Tadeusz; updates to quirk_intel_qat_vf_cap()]
> 
> On Mon, Sep 11, 2023 at 03:53:48PM +0300, Ilpo Järvinen wrote:
> > As the first step towards converting PCI accessor function return codes
> > into normal errnos this series cleans up related code paths which have
> > complicated multi-line construct to handle the PCI error checking.
> > 
> > I'd prefer these (the remaining ones) to be routed through PCI tree due
> > to PCI accessor function return code conversion being built on top of
> > them.
> > 
> > v3:
> > - Return pci_generic_config_read32()'s error code directly
> > - Removed already accepted patches
> > 
> > v2:
> > - Moved ret local var to the inner block (I2C: ali15x3)
> > - Removed already accepted patches
> > 
> > 
> > Ilpo Järvinen (6):
> >   alpha: Streamline convoluted PCI error handling
> >   sh: pci: Do PCI error check on own line
> >   atm: iphase: Do PCI error checks on own line
> >   PCI: Do error check on own line to split long if conditions
> >   PCI: xgene: Do PCI error check on own line & keep return value
> >   scsi: ipr: Do PCI error checks on own line
> > 
> >  arch/alpha/kernel/sys_miata.c      | 17 +++++++++--------
> >  arch/sh/drivers/pci/common.c       |  7 ++++---
> >  drivers/atm/iphase.c               | 20 +++++++++++---------
> >  drivers/pci/controller/pci-xgene.c |  7 ++++---
> >  drivers/pci/pci.c                  |  9 ++++++---
> >  drivers/pci/probe.c                |  6 +++---
> >  drivers/pci/quirks.c               |  6 +++---
> >  drivers/scsi/ipr.c                 | 12 ++++++++----
> >  8 files changed, 48 insertions(+), 36 deletions(-)
> 
> Applied all to pci/config-errs for v6.7, thanks!
> 
> I made the tweaks below; heads-up to John Paul and Tadeusz.
> 
> Oh, and weird experience applying these via b4, git am: the
> Signed-off-by was corrupted on these patches:
> 
>   https://lore.kernel.org/r/20230911125354.25501-7-ilpo.jarvinen@xxxxxxxxxxxxxxx  https://lore.kernel.org/r/20230911125354.25501-6-ilpo.jarvinen@xxxxxxxxxxxxxxx  https://lore.kernel.org/r/20230911125354.25501-3-ilpo.jarvinen@xxxxxxxxxxxxxxx
> 
> It looked like this:
> 
>   Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> 
> Not sure why this happened; maybe one of the mailing lists screwed it
> up and the order of arrival determines which one b4 uses?  The ones
> from linux-alpha look like:
> 
>   Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> 
> which I think corresponds to the bad rendering.  I think I fixed them
> all.

Thanks for letting me know. It seems that copies of the same mail

https://lore.kernel.org/linux-alpha/...
https://lore.kernel.org/linux-pci/...

do indeed differ for some reason. I'll probably have to experiment to see 
if I can reproduce problem with the linux-alpha list.


-- 
 i.