Re: [PATCH 09/13] x86/tdx: Account shared memory

From: kirill.shutemov@xxxxxxxxxxxxxxx
Date: Wed Oct 11 2023 - 09:15:07 EST


On Tue, Oct 10, 2023 at 10:05:21AM +0000, Huang, Kai wrote:
>
> > +#ifdef CONFIG_DEBUG_FS
> > +static int tdx_shared_memory_show(struct seq_file *m, void *p)
> > +{
> > + unsigned long addr, end;
> > + unsigned long found = 0;
> > +
> > + addr = PAGE_OFFSET;
> > + end = PAGE_OFFSET + get_max_mapped();
> > +
> > + while (addr < end) {
> > + unsigned long size;
> > + unsigned int level;
> > + pte_t *pte;
> > +
> > + pte = lookup_address(addr, &level);
> > + size = page_level_size(level);
> > +
> > + if (pte && pte_decrypted(*pte))
> > + found += size / PAGE_SIZE;
> > +
> > + addr += size;
>
> This could be a long loop, perhaps add cond_resched() here?

Sure.

--
Kiryl Shutsemau / Kirill A. Shutemov