Re: [PATCH v2 2/7] serial: amba-pl011: get rid of useless wrapper pl011_get_rs485_mode()

From: Lino Sanfilippo
Date: Wed Oct 11 2023 - 13:45:28 EST



Hi,

On 11.10.23 at 19:42, Greg KH wrote:
> On Wed, Oct 11, 2023 at 07:38:24PM +0200, Lino Sanfilippo wrote:
>> Due to earlier code changes function pl011_get_rs485_mode() is now merely
>> a wrapper for uart_get_rs485_mode() which does not add any further
>> functionality. So remove it and instead call uart_get_rs485_mode()
>> directly.
>>
>> Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>
>> Signed-off-by: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx>
>> ---
>> drivers/tty/serial/amba-pl011.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> Why is patch 2/7 not cc: stable, when patches 3-7 are? Either this
> patch isn't needed in this series, and can go later (or to a different
> branch), or it also needs to be marked for stable as the later patches
> depend on it?
>

2/7 is really only a cleanup patch that does not provide a bugfix.
Should I remove it from this series?

Regards,
Lino