Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT binding

[Krzysztof Kozlowski]

On 09/10/2023 23:04, Shawn Anastasio wrote:
>>> +
>>> +  leds:
>>> +    type: object
>>> +    description: Cronos Platform Status LEDs
>>
>> Missing additionalProperties:false... but anyway this is just empty. No
>> resources? Drop the node.
>>
> 
> Having nodes for the leds and the watchdog allows the two independent
> functions to be enabled/disabled in the device tree by adding/removing
> the relevant object. Would it be more idiomatic to instead introduce
> properties to the parent sie,cronos-cpld object to toggle these
> functions?

And why DT should be used to enable/disable them? Or are you suggesting
you have different devices under the same compatible?



Best regards,
Krzysztof