Re: [PATCH v8 25/34] ASoC: dt-bindings: Update example for enabling USB offload on SM8250

[Wesley Cheng]

Hi Rob,

On 10/10/2023 7:31 PM, Rob Herring wrote:
> On Tue, 10 Oct 2023 17:21:37 -0700, Wesley Cheng wrote:
> > Add an example on enabling of USB offload for the Q6DSP.  The routing can
> > be done by the mixer, which can pass the multimedia stream to the USB
> > backend.
> >
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Wesley Cheng <quic_wcheng@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/sound/qcom,sm8250.yaml    | 15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/sound/qcom,sm8250.example.dts:97.44-45 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/sound/qcom,sm8250.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
> make: *** [Makefile:234: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231011002146.1821-26-quic_wcheng@xxxxxxxxxxx
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

Would you happen to know what the error is in this case?  I made sure I 
was running the latest dtschema (v2023.9) and had yamllint installed as 
well.  When I took a look at the DTB and DTS output it looked ok...

            usb-dai-link {
                link-name = "USB Playback";
                cpu {
                    sound-dai = <&q6afedai USB_RX>;//--->syntax error?
                };

                codec {
                    sound-dai = <&usbdai USB_RX>;
                };

                platform {
                    sound-dai = <&q6routing>;
                };
            };

I didn't make any changes to this in between v7 and v8, but v7 passed:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230921214843.18450-25-quic_wcheng@xxxxxxxxxxx/

Thanks
Wesley Cheng