Re: [PATCH v2 2/2] arm64: dts: ti: k3-j784s4-main: Add BCDMA instance for CSI2RX

[Jayesh Choudhary]

On 10/10/23 16:47, Vaishnav Achath wrote:
> J784S4 has a dedicated BCDMA controller for the Camera Serial Interface.
> Events from the BCDMA controller instance are routed through the
> main UDMA interrupt aggregator as unmapped events. Add the node for
> the DMA controller and keep it disabled by default.
>
> See J784S4 Technical Reference Manual (SPRUJ52)
> for further details: http://www.ti.com/lit/zip/spruj52
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> ---
>
> V1->V2:
>      * Fix indentation for the reg entries.
>
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index efed2d683f63..3123413e2140 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -703,6 +703,7 @@
>   			ti,sci = <&sms>;
>   			ti,sci-dev-id = <321>;
>   			ti,interrupt-ranges = <0 0 256>;
> +			ti,unmapped-event-sources = <&main_bcdma_csi>;
>   		};
>   
>   		secure_proxy_main: mailbox@32c00000 {
> @@ -1000,6 +1001,22 @@
>   			ti,sci-rm-range-rflow = <0x00>; /* GP RFLOW */
>   		};
>   
> +		main_bcdma_csi: dma-controller@311a0000 {
> +			compatible = "ti,j721s2-dmss-bcdma-csi";
> +			reg = <0x00 0x311a0000 0x00 0x100>,
> +			      <0x00 0x35d00000 0x00 0x20000>,
> +			      <0x00 0x35c00000 0x00 0x10000>,
> +			      <0x00 0x35e00000 0x00 0x80000>;
> +			reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt";
> +			msi-parent = <&main_udmass_inta>;
> +			#dma-cells = <3>;
> +			ti,sci = <&sms>;
> +			ti,sci-dev-id = <281>;
> +			ti,sci-rm-range-rchan = <0x21>;
> +			ti,sci-rm-range-tchan = <0x22>;
> +			status = "disabled";
> +		};
> +

Reviewed-by: Jayesh Choudhary <j-choudhary@xxxxxx>

>   		cpts@310d0000 {
>   			compatible = "ti,j721e-cpts";
>   			reg = <0x00 0x310d0000 0x00 0x400>;