Re: [RFC PATCH 0/2] staging: rtl8192u: Fix two crashing bugs

From: Greg Kroah-Hartman
Date: Thu Oct 12 2023 - 02:35:51 EST


On Thu, Oct 12, 2023 at 08:02:58AM +0200, Philipp Hortmann wrote:
> Question: Fix or remove rtl8192u?

We should remove it if it's obviously broken and no one has reported it
in a very long time.

> I found a USB WLAN Stick with a rtl8192u. I got it last Saturday and
> found out that the firmware is missing in my ubuntu 20.04. I found it on
> the web and fixed it. When I started the driver my computer crashed. The
> missing part was: priv->priv_wq = alloc_workqueue("priv_wq", 0, 0);
> Fixing this the next error was a network = kzalloc(sizeof(*network),
> GFP_KERNEL); in wrong context which leads to a crash of my computer.
> Fixing this the next error is more depending on what I do with the stick.
>
> When lucky the connection is build up and I can surf and download at maximum speed (12,5MB/s) several gigabytes.

Do you want to keep it here so that you can maintain it and keep it
working?

thanks,

greg k-h