Re: [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers

[Linus Walleij]

On Wed, Oct 11, 2023 at 2:09 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:


> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> We have a set of pinctrl helpers for GPIOLIB drivers that take a number
> from the global GPIO numberspace as argument. We are trying to get rid
> of this global numbering. Let's rework these helpers to use the
> recommended gpio_chip + controller-relative offset instead.
>
> This work is split into phases: first let's introduce the new variants
> of the helpers. Next: let's convert all users one-by-one for easier
> review. After that let's remove the old helpers and rename the new
> variants to take the place of the old ones. Finally convert static
> functions in pinctrl/core.c to using the same signature and to top it
> off, let's remove now redundant wrappers around the pinctrl_helpers.
>
> This series introduces no functional changes in drivers so I decided to
> not spam every single driver maintainer anymore.
>
> v1 -> v2:
> - drop the conversion to using cleanup.h helpers as this is not the
>   subject of this series
> - split the patch renaming the new variants to the old names into
>   several patches that perform the operation step by step for easier
>   review
> - collect review tags and acks
> - add follow-up patches that drop the wrappers around pinctrl helpers
>   where applicable (where all the wrappers do is call the helper)
> - fix build error with PINCTRL disabled

I tried to apply the series for a test, with the intent to queue this for
v6.7, but there are conflicts toward both v6.6-rc1 and my pin control
devel branch, so I can't.

Since we are at -rc5 and the kernel looks better after the patches
than before I think they should just be applied and not held back
by minor review nits or process. But i couldn't.

I'm fine with the series as they are, but it looks like we need to queue
it at v6.7-rc1 for v6.8 or you need to send it to Torvalds after he
merged GPIO and pin control for v6.7, either works for me!

Yours,
Linus Walleij