Re: [PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier

[Muhammad Usama Anjum]

On 10/12/23 11:40 AM, Samasth Norway Ananda wrote:
> Definition for MREMAP_DONTUNMAP not present in the selftest for
> mremap_dontunmap thus throwing an undeclared error when running make
> on mm.
Thanks for sending the patch.

You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
glibc older than 2.32. So including linux/mman.h solves the build error for
people having older glibc. Please add this to the description of the patch
to give the exact reason this patch should be accepted.

> 
> Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@xxxxxxxxxxxxxx/
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@xxxxxxxxxx>
> ---
>  tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
> index ca2359835e75..a06e73ec8568 100644
> --- a/tools/testing/selftests/mm/mremap_dontunmap.c
> +++ b/tools/testing/selftests/mm/mremap_dontunmap.c
> @@ -7,6 +7,7 @@
>   */
>  #define _GNU_SOURCE
>  #include <sys/mman.h>
> +#include <linux/mman.h>
>  #include <errno.h>
>  #include <stdio.h>
>  #include <stdlib.h>
Tested-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

-- 
BR,
Muhammad Usama Anjum