Re: [PATCH] sunrpc: Use no_printk() in dfprintk*() dummies
From: Geert Uytterhoeven
Date: Thu Oct 12 2023 - 06:11:25 EST
On Thu, Oct 12, 2023 at 9:09 AM kernel test robot <lkp@xxxxxxxxx> wrote:
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on trondmy-nfs/linux-next]
> [also build test ERROR on linus/master v6.6-rc5 next-20231011]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Geert-Uytterhoeven/sunrpc-Use-no_printk-in-dfprintk-dummies/20231011-181013
> base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
> patch link: https://lore.kernel.org/r/707e5e6dd0db9a663cf443564d1f8ee1c10a0086.1697018818.git.geert%2Brenesas%40glider.be
> patch subject: [PATCH] sunrpc: Use no_printk() in dfprintk*() dummies
> config: alpha-defconfig (https://download.01.org/0day-ci/archive/20231012/202310121404.FMC1T6FF-lkp@xxxxxxxxx/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231012/202310121404.FMC1T6FF-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310121404.FMC1T6FF-lkp@xxxxxxxxx/
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/asm-generic/bug.h:22,
> from arch/alpha/include/asm/bug.h:23,
> from include/linux/bug.h:5,
> from include/linux/thread_info.h:13,
> from include/asm-generic/preempt.h:5,
> from ./arch/alpha/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:79,
> from include/linux/spinlock.h:56,
> from include/linux/mmzone.h:8,
> from include/linux/gfp.h:7,
> from include/linux/slab.h:16,
> from fs/lockd/svclock.c:25:
> fs/lockd/svclock.c: In function 'nlmsvc_lookup_block':
> >> fs/lockd/svclock.c:164:33: error: implicit declaration of function 'nlmdbg_cookie2a' [-Werror=implicit-function-declaration]
> 164 | nlmdbg_cookie2a(&block->b_call->a_args.cookie));
> | ^~~~~~~~~~~~~~~
> include/linux/printk.h:427:33: note: in definition of macro 'printk_index_wrap'
> 427 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> include/linux/printk.h:129:17: note: in expansion of macro 'printk'
> 129 | printk(fmt, ##__VA_ARGS__); \
> | ^~~~~~
> include/linux/sunrpc/debug.h:70:41: note: in expansion of macro 'no_printk'
> 70 | # define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~
> include/linux/sunrpc/debug.h:25:9: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/lockd/svclock.c:160:17: note: in expansion of macro 'dprintk'
> 160 | dprintk("lockd: check f=%p pd=%d %Ld-%Ld ty=%d cookie=%s\n",
> | ^~~~~~~
> >> fs/lockd/svclock.c:160:25: warning: format '%s' expects argument of type 'char *', but argument 7 has type 'int' [-Wformat=]
Thanks already fixed in v2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds