[PATCH v11 21/56] media: video-i2c: Set min_buffers_needed to 2

From: Benjamin Gaignard
Date: Thu Oct 12 2023 - 07:48:16 EST


vb2 queue_setup checks for a minimum number of buffers so set
min_buffers_needed to 2 and remove the useless check in video-i2c
queue_setup().

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
CC: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx>
---
drivers/media/i2c/video-i2c.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
index 178bd06cc2ed..0a38b9614764 100644
--- a/drivers/media/i2c/video-i2c.c
+++ b/drivers/media/i2c/video-i2c.c
@@ -406,9 +406,6 @@ static int queue_setup(struct vb2_queue *vq,
struct video_i2c_data *data = vb2_get_drv_priv(vq);
unsigned int size = data->chip->buffer_size;

- if (vq->num_buffers + *nbuffers < 2)
- *nbuffers = 2;
-
if (*nplanes)
return sizes[0] < size ? -EINVAL : 0;

@@ -794,7 +791,7 @@ static int video_i2c_probe(struct i2c_client *client)
queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
queue->drv_priv = data;
queue->buf_struct_size = sizeof(struct video_i2c_buffer);
- queue->min_buffers_needed = 1;
+ queue->min_buffers_needed = 2;
queue->ops = &video_i2c_video_qops;
queue->mem_ops = &vb2_vmalloc_memops;

--
2.39.2