Re: [PATCH] tty: serial: meson: hard LOCKUP on crtscts mode

From: pkrasavin
Date: Thu Oct 12 2023 - 08:36:05 EST


Hello Dmitry,

----- "Dmitry Rokosov" <ddrokosov@xxxxxxxxxxxxxxxxx> писал(а): -----

> Please do not use braces where is single statement. In other words:
>
> if (cflags & CRTSCTS) {
> if (port->flags & UPF_HARD_FLOW)
> val &= ~AML_UART_TWO_WIRE_EN;
> else
> termios->c_cflag &= ~CRTSCTS;
> } else {
> val |= AML_UART_TWO_WIRE_EN;
> }


thank you for your note, I will provide v2 without braces.

--
Regards,
Pavel.