Re: [PATCH v12 09/10] x86/resctrl: Add support for the files for MON groups only

From: Reinette Chatre
Date: Thu Oct 12 2023 - 12:04:50 EST


Hi Babu,

On 10/10/2023 4:33 PM, Babu Moger wrote:
> Files unique to monitoring groups have the RFTYPE_MON flag. When a new
> monitoring group is created the resctrl files with flags RFTYPE_BASE
> (files common to all resource groups) and RFTYPE_MON (files unique to
> monitoring groups) are created to support interacting with the new
> monitoring group.
>
> A resource group can support both monitoring and control, also termed
> a CTRL_MON resource group. CTRL_MON groups should get both monitoring
> and control resctrl files but that is not the case. Only the
> RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups.

There can be an empty line here to make this easier to read since that would
separate the problem from the solution.

> Ensure that files with the RFTYPE_MON flag are created for CTRL_MON groups.
>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> Tested-by: Peter Newman <peternewman@xxxxxxxxxx>
> Reviewed-by: Peter Newman <peternewman@xxxxxxxxxx>
> Tested-by: Tan Shaopeng <tan.shaopeng@xxxxxxxxxxxxxx>
> Reviewed-by: Tan Shaopeng <tan.shaopeng@xxxxxxxxxxxxxx>
> Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> --

Missing a "-" that will make the patch description not be as intended.

Reinette