Re: [PATCH] wifi: ath11k: Introduce and use ath11k_sta_to_arsta()

From: Kalle Valo
Date: Thu Oct 12 2023 - 12:08:47 EST


Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:

> Currently, the logic to return an ath11k_sta pointer, given a
> ieee80211_sta pointer, uses typecasting throughout the driver. In
> general, conversion functions are preferable to typecasting since
> using a conversion function allows the compiler to validate the types
> of both the input and output parameters.
>
> ath11k already defines a conversion function ath11k_vif_to_arvif() for
> a similar conversion. So introduce ath11k_sta_to_arsta() for this use
> case, and convert all of the existing typecasting to use this
> function.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

10c65f97b424 wifi: ath11k: Introduce and use ath11k_sta_to_arsta()

--
https://patchwork.kernel.org/project/linux-wireless/patch/20231009-ath11k_sta_to_arsta-v1-1-1563e3a307e8@xxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches