Re: [PATCH 1/1] perf build: Add missing comment about NO_LIBTRACEEVENT=1

From: Namhyung Kim
Date: Thu Oct 12 2023 - 13:23:23 EST


On Thu, Oct 5, 2023 at 8:45 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Thu, Oct 5, 2023 at 6:46 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> >
> > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> >
> > By default perf will fail the build if the development files for
> > libtraceevent are not available.
> >
> > To build perf without libtraceevent support, disabling several features
> > such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make
> > command line.
> >
> > Add the missing comments about that to the tools/perf/Makefile.perf
> > file, just like all the other such command line toggles.
> >
> > Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
> > Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Cc: Ian Rogers <irogers@xxxxxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Applied to perf-tools-next, thanks!