Re: [PATCH v2 0/4] hte: Improve GPIO handling and other cleanups

From: Dipen Patel
Date: Thu Oct 12 2023 - 13:38:29 EST


On 10/12/23 1:20 AM, Bartosz Golaszewski wrote:
> On Thu, Oct 12, 2023 at 12:59 AM Dipen Patel <dipenp@xxxxxxxxxx> wrote:
>>
>> On 10/11/23 1:26 PM, Andy Shevchenko wrote:
>>> This is a series that provides a new API to GPIO library (so far only
>>> available in the GPIO tree), and respective update to the Tegra
>>> HTE driver. On top a couple of other cleaups (patches 3 & 4, they
>>> can be applied separately).
>>>
>>> Patch 2 inherited tags from its respective discussion thread [1].
>>>
>>> Due to dependencies this either should be applied to the GPIO tree,
>>> or to the HTE when GPIO updates land the upstream (optionally with
>>> the first patch be applied even now to the GPIO tree independently).
>>>
>>> Another option is to have an immutable branch or tag, but I assume
>>> that was discussed and rejected (?) in [1].
>>>
>>> In v2:
>>> - collected tags (Linus, Dipen)
>>> - fixed couple of typos (Dipen)
>>>
>>> Link: https://lore.kernel.org/linux-gpio/20230905185309.131295-15-brgl@xxxxxxxx/ [1]
>>> Cc: Dipen Patel <dipenp@xxxxxxxxxx>
>>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>>
>>> Andy Shevchenko (3):
>>> gpiolib: provide gpio_device_find_by_fwnode()
>>> hte: tegra194: Remove redundant dev_err()
>>> hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS()
>>>
>>> Bartosz Golaszewski (1):
>>> hte: tegra194: don't access struct gpio_chip
>>>
>>> drivers/gpio/gpiolib.c | 20 ++++++++++++++++
>>> drivers/hte/hte-tegra194.c | 46 +++++++++++++++++++------------------
>>> include/linux/gpio/driver.h | 1 +
>>> 3 files changed, 45 insertions(+), 22 deletions(-)
>>>
>> Looks great...I am going to assume you are going to push patches 1 and 2 through
>> gpio subsystem and rest through HTE, right?
>>
>> Reviewed-by: Dipen Patel <dipenp@xxxxxxxxxx>
>> Tested-by: Dipen Patel <dipenp@xxxxxxxxxx>
>>
>
> Yes, let me queue them right away.
>
Thanks, I just pushed patches 3 and 4 to hte subsys tree. Thanks everyone for
the quick turnaround to resolve this issue.

> Bart