Re: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies

From: Michael Büsch
Date: Thu Oct 12 2023 - 13:40:38 EST


On Wed, 11 Oct 2023 20:44:49 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> > I thought about something like this:
> >
> > depends on (SSB_DRIVER_MIPS && PCI=n) || (SSB_DRIVER_MIPS &&
> > SSB_PCICORE_HOSTMODE)
> >
> > Would that solve the warning?
>
> Yes, that works as well, although I prefer to express it like this:
>
> config SSB_EMBEDDED
> bool
> - depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
> + depends on SSB_DRIVER_MIPS
> + depends on PCI=n || SSB_PCICORE_HOSTMODE
> default y

Acked-by: Michael Büsch <m@xxxxxxx>


--
Michael Büsch
https://bues.ch/

Attachment: pgpbm5psQjdgm.pgp
Description: OpenPGP digital signature