Re: [PATCH v3 1/2] ASoC: dt-bindings: sound-card-common: List DAPM endpoints ignoring system suspend

From: Rob Herring
Date: Thu Oct 12 2023 - 16:47:46 EST


On Wed, Oct 11, 2023 at 10:21:33PM +0100, Mark Brown wrote:
> On Wed, Oct 11, 2023 at 07:47:58PM +0800, Chancel Liu wrote:
>
> > + lpa-widgets:
> > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > + description: |
> > + A list of DAPM endpoints which mark paths between these endpoints should
> > + not be disabled when system enters in suspend state. LPA means low power
> > + audio case. For example on asymmetric multiprocessor, there are Cortex-A
>
> I suspect that the DT maintainers would prefer that this description be
> workshopped a bit to remove the Linux specifics.

And Cortex A/M specifics if this is a common binding.


> I think the key thing
> here is that these are endpoints that can be active over suspend of the
> main application processor that the current operating system is running
> (system DT stuff is an interesting corner case here...), and the example
> is probably a bit specific. Other bindings use "audio sound widgets"
> rather than "DAPM widgets".
>
> We also shouldn't see that these endpoints "should not be disabled"
> since that implies that they should be left on even if they aren't
> active which isn't quite the case, instead it's that we can continue
> playing an audio stream through them in suspend.

This seems like one of those things that everyone has/does, and everyone
handles it a bit differently. I applaud trying to do something common,
but it isn't really common until we have multiple users.

Rob