Re: [PATCH] rust: error: fix the description for `ECHILD`

From: Miguel Ojeda
Date: Thu Oct 12 2023 - 17:00:25 EST


On Mon, Oct 9, 2023 at 4:54 PM Benno Lossin <benno.lossin@xxxxxxxxx> wrote:
>
> Strictly speaking, `errno-base.h` documents this as "No child
> processes" (note the plural), but I am fine with taking it as-is.

Good catch.

POSIX seems to use both (General Information vs. `<errno.h>`), so
perhaps that is where Wedson picked it from.

Given the kernel uses the plural, and that the commit message says it
mimics `errno-base.h`, I have amended it.

Cheers,
Miguel

1: 77983c791960 ! 1: 17bfcd6a8153 rust: error: fix the description
for `ECHILD`
@@ Commit message
Fixes: 266def2a0f5b ("rust: error: add codes from `errno-base.h`")
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/r/20230930144958.46051-1-wedsonaf@xxxxxxxxx
+ [ Use the plural, as noticed by Benno. ]
Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

## rust/kernel/error.rs ##
@@ rust/kernel/error.rs: macro_rules! declare_err {
declare_err!(ENOEXEC, "Exec format error.");
declare_err!(EBADF, "Bad file number.");
- declare_err!(ECHILD, "Exec format error.");
-+ declare_err!(ECHILD, "No child process.");
++ declare_err!(ECHILD, "No child processes.");
declare_err!(EAGAIN, "Try again.");
declare_err!(ENOMEM, "Out of memory.");
declare_err!(EACCES, "Permission denied.");