Re: [PATCH v3 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 dts file

[Komal Bajaj]

On 10/7/2023 5:03 AM, Konrad Dybcio wrote:
> On 3.10.2023 19:54, Komal Bajaj wrote:
> > Add qcm6490 devicetree file for QCM6490 SoC and QCM6490 IDP
> > platform. QCM6490 is derived from SC7280 meant for various
> > form factor including IoT.
> >
> > Supported features are, as of now:
> > * Debug UART
> > * eMMC
> > * USB
> >
> > Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/Makefile        |   1 +
> >   arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 333 +++++++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/qcm6490.dtsi    |  94 +++++++
> >   3 files changed, 428 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> >   create mode 100644 arch/arm64/boot/dts/qcom/qcm6490.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 73c3be0f8872..3a2d9dbaacce 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -82,6 +82,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8998-sony-xperia-yoshino-maple.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= msm8998-sony-xperia-yoshino-poplar.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= msm8998-xiaomi-sagit.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= qcm6490-fairphone-fp5.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= qcm6490-idp.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= qcs404-evb-1000.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= qcs404-evb-4000.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= qdu1000-idp.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > new file mode 100644
> > index 000000000000..d81a7810fd5a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > @@ -0,0 +1,333 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > +#include "pm7325.dtsi"
> > +#include "pm8350c.dtsi"
> > +#include "pmk8350.dtsi"
> > +#include "qcm6490.dtsi"
> As the kernel robot pointed out, this has clearly not even been
> compile-tested..

Sorry for this.. I made this change as per the comment that I got to 
sort the
inclusion files in alphabetical order. Incremental build compilation 
wasn't able
to catch this error.
I will move qcm6490.dtsi file inclusion before pm* files inclusion.

Thanks
Komal

> Konrad