Re: [PATCH 1/4] dt-bindings: reset: Add syscon to nuvoton ma35d1 system-management node

[Jacky Huang]

Dear Rob,

Thank you for the review.

On 2023/10/13 上午 04:39, Rob Herring wrote:
> On Wed, Oct 11, 2023 at 09:05:07AM +0000, Jacky Huang wrote:
> > From: Jacky Huang <ychuang3@xxxxxxxxxxx>
> >
> > Add compatible 'syscon' to the system-management node.
> >
> > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml        | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml
> > index 34c5c1c08ec1..3ce7dcecd87a 100644
> > --- a/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml
> > +++ b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml
> > @@ -18,6 +18,7 @@ properties:
> >     compatible:
> >       items:
> >         - const: nuvoton,ma35d1-reset
> > +      - const: syscon
> Presumably you already have a driver for nuvoton,ma35d1-reset, so just
> make it create a regmap. I assume this is the reason you want to add
> 'syscon'?
>
> Rob

Yes, we have a driver for 'nuvoton,ma35d1-reset' with a register space 
mapped to
the system control registers. The other ma35d1 drivers may also require 
access
to the system control registers. I added 'syscon' to this node so that 
other drivers
can utilize 'regmap' via the phandle of this node.

Best Regards,
Jacky Huang