Re: [PATCH] perf/x86/amd/uncore: fix error codes in amd_uncore_init()

From: Dan Carpenter
Date: Fri Oct 13 2023 - 04:12:18 EST


On Fri, Oct 13, 2023 at 09:30:46AM +0200, Ingo Molnar wrote:
> Ugh, why on Earth didn't GCC warn about this? The bad pattern is pretty
> simple & obvious once pointed out ... compilers should have no trouble
> realizing that 'ret' is returned uninitialized in some of these control
> paths. Yet not a peep from the compiler ...

We disabled that warning years ago (5?) because GCC had too many false
positives.

regards,
dan carpenter