Re: [PATCH v2 1/4] mtd: rawnand: Add destructive operation
From: Miquel Raynal
Date: Fri Oct 13 2023 - 04:48:22 EST
Hello,
dregan@xxxxxxxx wrote on Thu, 12 Oct 2023 19:36:11 +0200:
> Hi Miquel,
>
> > Sent: Thursday, October 12, 2023 at 12:06 AM
> > From: "Miquel Raynal" <miquel.raynal@xxxxxxxxxxx>
> > To: dregan@xxxxxxxx
> > Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, f.fainelli@xxxxxxxxx, rafal@xxxxxxxxxx, joel.peshkin@xxxxxxxxxxxx, computersforpeace@xxxxxxxxx, dan.beygelman@xxxxxxxxxxxx, william.zhang@xxxxxxxxxxxx, frieder.schrempf@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, vigneshr@xxxxxx, richard@xxxxxx, bbrezillon@xxxxxxxxxx, kdasu.kdev@xxxxxxxxx, "JaimeLiao" <jaimeliao.tw@xxxxxxxxx>, "Arseniy Krasnov" <AVKrasnov@xxxxxxxxxxxxxx>, "Adam Borowski" <kilobyte@xxxxxxxxxx>
> > Subject: Re: [PATCH v2 1/4] mtd: rawnand: Add destructive operation
> >
> > Hello,
> >
> > dregan@xxxxxxxx wrote on Thu, 12 Oct 2023 02:40:35 +0200:
> >
> > The author should be Boris as well (git commit --amend --author=...)
>
> I will attempt to change the author but git seems to be
> somewhat limited in what I can accomplish when it comes to
> changing emails, sending in the name of someone else etc.
>
> >
> > > Erase and program operations need the write protect (wp) pin to be
> > > de-asserted to take effect. Add the concept of destructive
> > > operation and pass the information to exec_op() so controllers know
> > > when they should de-assert this pin without having to decode
> > > the command opcode.
> > >
> > > Created by Boris Brezillon.
> >
> > This can go away.
>
> Will remove.
>
> >
> > >
> > > https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717
> >
> > This as well.
>
> Will also remove.
>
> >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> >
> > Please use Boris' kernel.org e-mail for the authorship and SoB
>
> I don't know what Boris' kernel.org email address?
> Is it @bootlin? Collabora still shows up as email when
> I do the list of maintainers. I did some searching
> but couldn't really find anything conclusive.
It's in .mailmap: bbrezillon@xxxxxxxxxx
> > > Signed-off-by: David Regan <dregan@xxxxxxxx>
>
> Do I still keep this SOB or should I change it to something else?
You need both SoB: his then yours.
Thanks,
Miquèl