Re: [PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

[Alexander Stein]

Hi Iuliana,

Am Freitag, 13. Oktober 2023, 10:35:17 CEST schrieb Iuliana Prodan:
> Hi Alexander,
> 
> On 10/11/2023 8:37 AM, Alexander Stein wrote:
> > Hi Iuliana,
> > 
> > Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS):
> >> From: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> >> 
> >> Add the reserve-memory nodes used by DSP when the rpmsg
> >> feature is enabled.
> >> 
> >> Signed-off-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> >> ---
> >> 
> >>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> >>   1 file changed, 16 insertions(+)
> >> 
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> >> cc406bb338fe..22815b3ea890 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> @@ -211,6 +211,22 @@
> >> 
> >>   			reg = <0 0x92400000 0 0x2000000>;
> >>   			no-map;
> >>   		
> >>   		};
> >> 
> >> +
> >> +		dsp_vdev0vring0: vdev0vring0@942f0000 {
> >> +			reg = <0 0x942f0000 0 0x8000>;
> >> +			no-map;
> >> +		};
> >> +
> >> +		dsp_vdev0vring1: vdev0vring1@942f8000 {
> >> +			reg = <0 0x942f8000 0 0x8000>;
> >> +			no-map;
> >> +		};
> >> +
> >> +		dsp_vdev0buffer: vdev0buffer@94300000 {
> >> +			compatible = "shared-dma-pool";
> >> +			reg = <0 0x94300000 0 0x100000>;
> >> +			no-map;
> >> +		};
> > 
> > Please configure these reserved memories on board level. Not every i.MX8MP
> > based board uses this DSP or has these memory addresses available.
> 
> Will it be ok in imx8mp-evk.dts?

If that is the board using the DSP and the reserved memory, then yes.

Best regards,
Alexander

> Thanks,
> Iulia
> 
> > Best regards,
> > Alexander
> > 
> >>   	};
> >>   	
> >>   	pmu {


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/