Re: [kernel PATCH v2] Bluetooth: btmtksdio: enable bluetooth wakeup in system suspend

From: kernel test robot
Date: Fri Oct 13 2023 - 06:24:57 EST


Hi Zhengping,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.6-rc5 next-20231012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Zhengping-Jiang/Bluetooth-btmtksdio-enable-bluetooth-wakeup-in-system-suspend/20231012-064116
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20231011153928.kernel.v2.1.I6dbfc1fedddf0633b55ce7e7a10ef7f3929a9bdc%40changeid
patch subject: [kernel PATCH v2] Bluetooth: btmtksdio: enable bluetooth wakeup in system suspend
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20231013/202310131817.oEUPvya8-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231013/202310131817.oEUPvya8-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310131817.oEUPvya8-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/bluetooth/btmtksdio.c:1501:12: warning: 'btmtksdio_system_resume' defined but not used [-Wunused-function]
1501 | static int btmtksdio_system_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btmtksdio.c:1464:12: warning: 'btmtksdio_system_suspend' defined but not used [-Wunused-function]
1464 | static int btmtksdio_system_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/btmtksdio_system_resume +1501 drivers/bluetooth/btmtksdio.c

1463
> 1464 static int btmtksdio_system_suspend(struct device *dev)
1465 {
1466 struct sdio_func *func = dev_to_sdio_func(dev);
1467 struct btmtksdio_dev *bdev;
1468
1469 bdev = sdio_get_drvdata(func);
1470 if (!bdev)
1471 return 0;
1472
1473 if (!test_bit(BTMTKSDIO_FUNC_ENABLED, &bdev->tx_state))
1474 return 0;
1475
1476 set_bit(BTMTKSDIO_BT_WAKE_ENABLED, &bdev->tx_state);
1477
1478 return btmtksdio_runtime_suspend(dev);
1479 }
1480
1481 static int btmtksdio_runtime_resume(struct device *dev)
1482 {
1483 struct sdio_func *func = dev_to_sdio_func(dev);
1484 struct btmtksdio_dev *bdev;
1485 int err;
1486
1487 bdev = sdio_get_drvdata(func);
1488 if (!bdev)
1489 return 0;
1490
1491 if (!test_bit(BTMTKSDIO_FUNC_ENABLED, &bdev->tx_state))
1492 return 0;
1493
1494 err = btmtksdio_drv_pmctrl(bdev);
1495
1496 bt_dev_dbg(bdev->hdev, "status (%d) get ownership from device", err);
1497
1498 return err;
1499 }
1500
> 1501 static int btmtksdio_system_resume(struct device *dev)
1502 {
1503 return btmtksdio_runtime_resume(dev);
1504 }
1505

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki