Re: [PATCH] crypto: hisilicon/qm - alloc buffer to set and get xqc

From: Herbert Xu
Date: Fri Oct 13 2023 - 06:40:05 EST


On Sun, Oct 08, 2023 at 08:36:17PM +0800, Weili Qian wrote:
> If the temporarily applied memory is used to set or get the xqc
> information, the driver releases the memory immediately after the
> hardware mailbox operation time exceeds the driver waiting time.
> However, the hardware does not cancel the operation, so the hardware
> may write data to released memory.
>
> Therefore, when the driver is bound to a device, the driver reserves
> memory for the xqc configuration. The subsequent xqc configuration
> uses the reserved memory to prevent hardware from accessing the
> released memory.
>
> Signed-off-by: Weili Qian <qianweili@xxxxxxxxxx>
> ---
> drivers/crypto/hisilicon/debugfs.c | 75 +++---
> drivers/crypto/hisilicon/qm.c | 332 ++++++++++++---------------
> drivers/crypto/hisilicon/qm_common.h | 5 +-
> include/linux/hisi_acc_qm.h | 13 ++
> 4 files changed, 191 insertions(+), 234 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt