Re: [PATCH V2 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485

From: m . brock
Date: Fri Oct 13 2023 - 07:17:52 EST


Rob Herring wrote on 2023-10-12 22:51:
How about introducing an rs485 generic gpios property instead of xlnx
private one? See also rs485-term-gpios and rs485-rx-during-tx-gpios.

Also note that every kernel driver expects to use RTS for this purpose.
So why not give this driver the option to choose a gpio instead of its
native RTS? And from there on use the rts route?
What if someone wants to use normal (non-rs485) RTS on a GPIO instead
of the native pin?

@Rob Herring
I am curious to know how the rs485 maintainers look at this.

Ask them.

Funny, your name is the only one listed under the maintainers in
Documentation/devicetree/bindings/serial/rs485.yaml

And there is no mention of (RS-)485 in MAINTAINERS.

We already have 'rts-gpios'. If that's what's always used, then perhaps
we should use that in the RS485 case too?

Rob

Sounds like a good idea.

Maarten