Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

[Mark Brown]

On Fri, Oct 13, 2023 at 01:50:41PM +0200, Krzysztof Kozlowski wrote:
> On 13/10/2023 12:42, wangweidong.a@xxxxxxxxxx wrote:

> > +static void aw88399_hw_reset(struct aw88399 *aw88399)
> > +{
> > +	if (aw88399->reset_gpio) {
> > +		gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
> > +		usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
> > +		gpiod_set_value_cansleep(aw88399->reset_gpio, 1);

> Why do you leave the device in reset state? I think you wanted these
> reverted.

I imagine practical systems aren't using the inversion that gpiolib can
do via the bindings, this is already the case for the other drivers
sharing the binding.  TBH the use for things like reset lines has always
seemed like it causes more confusion and error than it solves.

Attachment: signature.asc
Description: PGP signature