Re: [PATCH 4/6] platform/x86: wmi: Fix probe failure when failing to register WMI devices

[Armin Wolf]

Am 12.10.23 um 18:32 schrieb Ilpo Järvinen:

> On Sun, 8 Oct 2023, Armin Wolf wrote:
>
> > When a WMI device besides the first one somehow fails to register, retval
> > is returned while still containing a negative error code. This causes the
> > ACPI device failing to probe, leaving behind zombie WMI devices leading
> > to various errors later.
> > Fix this by handling the single error path separately and return 0 after
> > trying to register all WMI devices. Also continue to register WMI devices
> > even if some fail to allocate.
> I think the usual approach would be to unroll all registerations done so
> far when an error occurs while registering n devices.

I agree, however the surrounding code unrolls only the WMI device registration,
so i kept it that way. After all, this patch focuses on fixing the "zombie" WMI devices
problem, so changing the code to unroll all registrations should be done in a separate
patch IMHO.

Armin Wolf

> Do you Hans have something to add what would be the best course of action
> here?